• sugar_in_your_tea
    link
    fedilink
    English
    arrow-up
    1
    ·
    8 months ago

    Awesome! It’s impressive that it’s decently close in performance with no unsafe code. Thanks for your hard work!

    And that Go implementation is pretty fast too! That’s quite impressive.

    • Killing_Spark@feddit.de
      link
      fedilink
      English
      arrow-up
      1
      ·
      8 months ago

      Sadly it does have one place with unsafe code. I needed a ringbuffer with an efficient “extend from within” implementation. I always wanted to contribute that to the standard library to actually get to no unsafe.

      • sugar_in_your_tea
        link
        fedilink
        English
        arrow-up
        1
        ·
        8 months ago

        Ah, I saw a PR from like 3 years ago that removed it, so it looks like you added it back in for performance.

        Have you tried contributing it upstream? I’m not a “no unsafe” zealot, but in light of the xz issue, it would be nice.

        • Killing_Spark@feddit.de
          link
          fedilink
          English
          arrow-up
          1
          ·
          8 months ago

          Have you tried contributing it upstream?

          I didn’t yet just because I didn’t get around to it (and because I am not sure the std lib even wants this feature).

          I’m not a “no unsafe” zealot, but in light of the xz issue, it would be nice.

          I don’t think the two relate. I wouldn’t drop any dependency, the ringbuffer is implemented in the same repo.

          • sugar_in_your_tea
            link
            fedilink
            English
            arrow-up
            1
            ·
            8 months ago

            Yeah, they’re not really related. I’m just thinking there might be more scrutiny on compression due to the exploit.

            That said, yours doesn’t support encoding anyway, so it’s kind of moot.