• sugar_in_your_tea
    link
    fedilink
    English
    arrow-up
    1
    ·
    2 年前

    Ah, I saw a PR from like 3 years ago that removed it, so it looks like you added it back in for performance.

    Have you tried contributing it upstream? I’m not a “no unsafe” zealot, but in light of the xz issue, it would be nice.

    • Killing_Spark@feddit.de
      link
      fedilink
      English
      arrow-up
      1
      ·
      2 年前

      Have you tried contributing it upstream?

      I didn’t yet just because I didn’t get around to it (and because I am not sure the std lib even wants this feature).

      I’m not a “no unsafe” zealot, but in light of the xz issue, it would be nice.

      I don’t think the two relate. I wouldn’t drop any dependency, the ringbuffer is implemented in the same repo.

      • sugar_in_your_tea
        link
        fedilink
        English
        arrow-up
        1
        ·
        2 年前

        Yeah, they’re not really related. I’m just thinking there might be more scrutiny on compression due to the exploit.

        That said, yours doesn’t support encoding anyway, so it’s kind of moot.