Which of these code styles do you find preferable?

First option using mut with constructor in the beginning:

  let mut post_form = PostInsertForm::new(
    data.name.trim().to_string(),
    local_user_view.person.id,
    data.community_id,
  );
  post_form.url = url.map(Into::into);
  post_form.body = body;
  post_form.alt_text = data.alt_text.clone();
  post_form.nsfw = data.nsfw;
  post_form.language_id = language_id;

Second option without mut and constructor at the end:

  let post_form = PostInsertForm {
    url: url.map(Into::into),
    body,
    alt_text: data.alt_text.clone(),
    nsfw: data.nsfw,
    language_id,
    ..PostInsertForm::new(
      data.name.trim().to_string(),
      local_user_view.person.id,
      data.community_id,
    )
  };

You can see the full PR here: https://github.com/LemmyNet/lemmy/pull/5037/files

  • taladar
    link
    fedilink
    arrow-up
    2
    ·
    2 months ago

    Why not just a let app = app; line after the let mut app = ...; one?

    • al4s@feddit.org
      link
      fedilink
      arrow-up
      2
      ·
      2 months ago

      A scope groups the initialization visually together, while adding the let app = app; feels like it just adds clutter - I’d probably just leave it mut in that case.

      • BB_C@programming.dev
        link
        fedilink
        arrow-up
        3
        ·
        2 months ago

        Rebinding with and without mut is a known and encouraged pattern in rust. Leaving things as mut longer than necessary is not.

      • taladar
        link
        fedilink
        arrow-up
        1
        ·
        2 months ago

        But a scope adds a nesting level which adds a lot more visual clutter.