• m_f@midwest.social
    471·
    11 months ago

    The collect’s in the middle aren’t necessary, neither is splitting by ": ". Here’s a simpler version

    fn main() {
    let text = "seeds: 79 14 55 13\nwhatever";
    let seeds: Vec<_> = text
        .lines()
        .next()
        .unwrap()
        .split_whitespace()
        .skip(1)
        .map(|x| x.parse::().unwrap())
        .collect();
    println!("seeds: {:?}", seeds);
}

    It is simpler to bang out a [int(num) for num in text.splitlines()[0].split(' ')[1:]] in Python, but that just shows the happy path with no error handling, and does a bunch of allocations that the Rust version doesn’t. You can also get slightly fancier in the Rust version by collecting into a Result for more succinct error handling if you’d like.

    EDIT: Here’s also a version using anyhow for error handling, and the aforementioned Result collecting:

    use anyhow::{anyhow, Result};

fn main() -> Result<()> {
    let text = "seeds: 79 14 55 13\nwhatever";
    let seeds: Vec = text
        .lines()
        .next()
        .ok_or(anyhow!("No first line!"))?
        .split_whitespace()
        .skip(1)
        .map(str::parse)
        .collect::>()?;
    println!("seeds: {:?}", seeds);
    Ok(())
}
    • MaliciousKebabOPEnglish
      6·
      11 months ago

      Yeah I was trying to do something like reading the first line by getting an iterator and just looping through the other lines normally, since first line was kind of a special case but it got messy quick. I realized halfway that my collects were redundant but couldn’t really simplify it. Thanks

    • lad@programming.dev
      2·
      11 months ago

      Also, anyhow::Context provides a convenient way to turn Option and Result> into anyhow::Result

      Like this:

      use anyhow::Context;

// to my understanding it's better to 
// specify the types when their names 
// are the same as in prelude to improve
// readability and reduce name clashing
fn main() -> anyhow::Result<()> {
    let text = "seeds: 79 14 55 13\nwhatever";
    let seeds: Vec = text
        .lines()
        .next()
        .context("No first line!")?     // This line has changed
        .split_whitespace()
        .skip(1)
        .map(str::parse)
        .collect::>()?;
    println!("seeds: {:?}", seeds);
    Ok(())
}

      Edit: line breaks

    • MaliciousKebabOPEnglish
      11·
      11 months ago

      Yeah ngl it’s very ugly. But hey as long as it works it’s not stupid amirite?

      • xlash123
        6·
        11 months ago

        Rust borrows a lot of it’s design from functional programming languages like Haskell, which has its good and bad. You could also choose to implement this behavior iteratively like typical C programs, but that tends to be ugly in other ways.

        Personally, I’ve grown fond of the functional style. You see it in other places too, like the higher order functions in JavaScript. What’s good about them in Rust is you still get amazing performance due to zero-cost abstraction. Trying to implement it yourself would likely be slower, so use them any chance you get.

            • crispy_kilt@feddit.de
              1·
              11 months ago

              I don’t think it would be readable. Too much going on. You’d need an outer iter over lines, an inner over words, a check for number and a conversion. And there would be zero error handling.

              • AVincentInSpace@pawb.socialEnglish
                2·
                11 months ago

                No less readable than half the Python comprehensions I’ve written.

                zero error handling.

                Not necessarily. The macro could look for a ? at the end of the final expression (the bit that comes first in a comprehension) and return a Result.