• ernest@kbin.social
    link
    fedilink
    arrow-up
    59
    arrow-down
    9
    ·
    1 year ago

    Since then, over 230 pull requests have been accepted. I had a branch where I was working on this, but a lot of code has changed in the meantime - among other things, ex the markdown implementation has been rewritten and, in fact, some of it is now outdated. Many files will still change and be rewritten before the release.

    Before the first release, it will be done properly, and I will probably seek help and consultation from the right people https://codeberg.org/Kbin/kbin-core/pulls/937. Currently, in the project’s readme, I’ve clearly indicated that kbin is inspired by Postmill. Unfortunately, recently I’ve been overwhelmed by some personal matters, which caused me to neglect certain things. Now I’m doing everything to bring kbin to the appropriate state.

    • Bendersnose@lemmy.blahaj.zoneOP
      link
      fedilink
      arrow-up
      49
      arrow-down
      14
      ·
      edit-2
      1 year ago

      “Inspired” is not an honest term. You’re using someone else’s code, so abide by the license they use, or remove their code from your project until you’re ready to follow the license. You started lifting Postmill’s code several years ago now and have had sooo much time to set things right but keep dragging your feet.

      This isn’t a school project, you’re gaining financially from someone else’s hard work without abiding by their (incredibly permissive) FOSS license and opening yourself up to serious legal action.

      • ernest@kbin.social
        link
        fedilink
        arrow-up
        17
        arrow-down
        6
        ·
        1 year ago

        As I said, the markdown implementation that received the main thing has been rewritten by contributors. I need to consult on how it should look in such a case. Now the indicated similarities are between these files (these files will also be changed soon, before release):

        https://codeberg.org/Kbin/kbin-core/src/branch/develop/src/Repository/Criteria.php
        https://gitlab.com/postmill/Postmill/-/blob/1e98b99bc4a20b396f2fa4089bdb1a308b7e18fd/src/SubmissionFinder/Criteria.php
        https://gitlab.com/postmill/Postmill/-/blob/a9704316c1c78f15ca12c2dc5ad477f4ac9f530e/src/Entity/Submission.php#L21-57

        • Bendersnose@lemmy.blahaj.zoneOP
          link
          fedilink
          arrow-up
          26
          arrow-down
          7
          ·
          1 year ago

          May I ask why you haven’t added the copyright notice to make kbin compliant while your volunteers are in the process of eliminating all of Postmill’s code from the code base?

            • ernest@kbin.social
              link
              fedilink
              arrow-up
              10
              arrow-down
              3
              ·
              1 year ago

              Most of the indicated code is no longer part of kbin (unlike Pixelfed’s code, to be fair). You can see the similarities in the links provided above. However, I need to thoroughly analyze everything once again to make sure nothing slipped past me and there isn’t more of it. There might be a tool that could facilitate this. In any case, it’s not my intention to hide the original source, even if major changes have been made. I’d gladly leave information about what the code was based on. I have no problem with that, the only enemy is time.

          • ernest@kbin.social
            link
            fedilink
            arrow-up
            14
            arrow-down
            6
            ·
            1 year ago

            I think several factors contributed to this. First, I prepared the licensing tag, but when the time came to merge the branch - that code simply no longer existed. As you can see, the remaining files are what I call inspiration - it’s not copied code but more of an overall concept, quite common in these types of applications (however, I’m not saying that there shouldn’t be a tag). Another factor is that sometimes you have to choose what to focus on first - eliminate and remove thousands of spambots, fix activitypub communication after updates from other software so as not to crash your server and others, secure the instance from sensitive content, deal with all the formalities related to the legal situation, working on moteration tools, handle pull requests from people who dedicate their private time to it and many more. Additional, I still need to make sure I can pay my own bills, and there’s personal life.

            And yes, two months is a long time, but for me, it was just a flash this time. A swift reality check occurred because the first release was supposed to come out over a month ago. I’m doing this the best I can, and without the help of contributors, none of this would have been possible. Due to the situation, I have to prioritize certain tasks. This is still marked as high priority, but it’s waiting its turn. Nevertheless, I have the opportunity, I decided to seek external help to do it the right way before releasing the first version. I realized that it only seems like a simple task on the surface. I want close the matter once and for all. All of this also pertains to the licensing tags of Pixelfed, btw.

            • Bendersnose@lemmy.blahaj.zoneOP
              link
              fedilink
              arrow-up
              13
              arrow-down
              41
              ·
              1 year ago

              Gosh, how long did it take you to type that long reply explaining you’re too busy to copy a license file over to kbin? It takes less than a minute to do. Copy the file. Commit. That’s it.

              • shnurr@fludiblu.xyz
                link
                fedilink
                English
                arrow-up
                21
                arrow-down
                6
                ·
                1 year ago

                People sitting on their ass telling others what they should do because “it only takes a minute” is such a stereotype in FOSS that I didn’t think I would see a real one in the wild. Wow.

                • LinkOpensChest.wav@lemmy.one
                  link
                  fedilink
                  arrow-up
                  1
                  ·
                  1 year ago

                  sitting on their ass

                  What action do you think OP should be taking? Legal action? I don’t see how criticizing OP for “sitting on their ass” is really a fair criticism.

              • ernest@kbin.social
                link
                fedilink
                arrow-up
                16
                arrow-down
                2
                ·
                1 year ago

                It took me from 4 to 6 minutes, I can’t determine exactly. I think this is about more than just copying and committing a file - one needs to label specific files or sections of the code. I’m not sure how exactly this should look, so I’m waiting for a consultation.

              • gerryflap@feddit.nl
                link
                fedilink
                arrow-up
                10
                arrow-down
                2
                ·
                edit-2
                1 year ago

                You realize this is one human being managing this whole situation without getting paid? Being nice enough to share a cool, if imperfect, piece of software for all to use. Show some respect, damn. Kbin has exploded in the the past months, leading to a lot of exposure and thus also suddenly an onslaught of things to fix. License errors definitely aren’t great, but you can’t fix everything at once.

  • sabreW4K3@lemmy.tf
    link
    fedilink
    English
    arrow-up
    40
    arrow-down
    4
    ·
    edit-2
    1 year ago

    The fact that Ernest commented on this two months ago and then didn’t fix the issue is saddening. I understand that everyone is busy, but crediting people isn’t a big ask.

  • 𝒍𝒆𝒎𝒂𝒏𝒏@lemmy.one
    link
    fedilink
    arrow-up
    35
    arrow-down
    13
    ·
    1 year ago

    Life happens IMO.

    Any reason why the people repeatedly raising the issue don’t just open a PR in Codeberg adding the attribution they deem “correct”? This isn’t a court house, the source control tool is literally an open forum…

    Am I missing something here?

    • priapus
      link
      fedilink
      English
      arrow-up
      14
      arrow-down
      3
      ·
      1 year ago

      This is the responsibility of the person who wrote the code. This person is ernest. Life happens, but this is not a significant amount of work to be done and ernest said it would be done “today” 2 months ago.

    • Bendersnose@lemmy.blahaj.zoneOP
      link
      fedilink
      arrow-up
      22
      arrow-down
      15
      ·
      1 year ago

      You’re shifting the blame. Ernest promised a quick resolution 2 months ago and didn’t follow through. I don’t use kbin, I only use Postmill, so expecting me to clean up his mess isn’t a reasonable ask.

      It would take him less time to copy/paste the license file than it took him to write his latest feet-dragging comment here.

      • 𝒍𝒆𝒎𝒂𝒏𝒏@lemmy.one
        link
        fedilink
        arrow-up
        21
        arrow-down
        9
        ·
        1 year ago

        You’re shifting the blame

        I don’t see how I am…

        Ernest promised a quick resolution 2 months ago and didn’t follow through.

        I understand that, and it’s unfortunate that he’s been unable to do so thus far.

        That fact does not affect the validity of the original question IMO, especially when the complaint is originating from multiple people who each have equal access to implement the desired change.

        I don’t use kbin, I only use Postmill, so expecting me to clean up his mess isn’t a reasonable ask

        I’m not expecting a specific individual to “clean up his mess” really. There are multiple people being vocal about this issue besides yourself, from my perspective any one of these individuals can do this and move on.

        It would take him less time to copy/paste the license file than it took him to write his latest feet-dragging comment here

        While this is true, I think posts like these are also wasting his time needing to crowd control a post discussing how he should be using his personal time. These kind of interactions are really demotivating and draining for any developer or individual

        Even if he went and did the change himself as a result of this post, people would still “why did it take you this long” and the like IMO

  • AnonymousLlama@kbin.social
    link
    fedilink
    arrow-up
    24
    arrow-down
    3
    ·
    1 year ago

    I’ve raised this in the matrix chat and have flagged this again to Ernest. I know initially about 2 months ago when the exodus happened that he was scrambling around trying to keep the server running as everyone joined.

    Over the last few weeks he’s be busy with a flood of PRs with either fixes, new features or support for the upcoming API integration.

    I had no idea this ticket existed (mostly because there’s been almost 1000 tickets submitted and I’ve been working on improvements)

    Hopefully he can have a look at this and fix these issues soon, I seriously don’t think this was done maliciously, but I’ll do what I can to raise it (I have minimal exposure to open source licensing so I don’t want to touch these files myself)

    • aard@kyu.de
      link
      fedilink
      arrow-up
      14
      ·
      1 year ago

      I also was almost dismissing it as “who let raddle out of the box again”, but this is indeed a valid complaint, which even is easy enough for kbin to become compliant - so I also don’t see why they didn’t do it immediately when it was pointed out.

          • woelkchen@lemmy.world
            link
            fedilink
            arrow-up
            7
            arrow-down
            4
            ·
            1 year ago

            This was 2 months ago with absolutely nothing happening when there really isn’t much required.

            I get this is a legitimate complaint but why did no one just open a pull request and fix the issue?

            • AnonymousLlama@kbin.social
              link
              fedilink
              arrow-up
              5
              ·
              1 year ago

              I can’t speak for the other contributors but there’s been almost 1000 tickets in the space of 2-3 months. I’ve been fairly busy fixing bugs and trying to improve the UI. I’ve flagged it to ernest and hopefully this gets resolved soon so we can keep everyone happy 🦙

              • woelkchen@lemmy.world
                link
                fedilink
                arrow-up
                4
                arrow-down
                3
                ·
                1 year ago

                If that’s the attitude, be hostile and have no empathy for someone who outright says it’s his fault but who’s also overworked, then why not sue? Seems that’s the attitude you’re projecting.

  • gsa4555@lemm.ee
    link
    fedilink
    arrow-up
    5
    arrow-down
    29
    ·
    edit-2
    1 year ago

    Heard they stole it from a trans woman. Wouldn’t that make the kbin dev transphobic?

    Edit: Wow a lot of transphobes already downvoting ne

    • VerifiablyMrWonka@kbin.social
      link
      fedilink
      arrow-up
      16
      ·
      1 year ago

      Only in the same way that stealing code from a PoC would make me racist, stealing code from a Jew would make me anti-semitic or stealing code from a woman would make me sexist.

      Since, without proof of any of that you’re just making shit up I’m going to go with the reason that your post is being downvoted is that ITS JUST FUCKING STUPID.

      • AnonymousLlama@kbin.social
        link
        fedilink
        arrow-up
        5
        ·
        edit-2
        1 year ago

        Actually had to re-read old mates comment above us to see if I was missing satire / sarcasm. Like no way anyone legitimately thinks like this? 🤯

      • Bendersnose@lemmy.blahaj.zoneOP
        link
        fedilink
        arrow-up
        2
        arrow-down
        7
        ·
        edit-2
        1 year ago

        Please don’t derail the thread with this accusation, you’re not helping. Stick to the topic at hand (the license being willfully violated) and don’t speculate.

    • Cylusthevirus@kbin.social
      link
      fedilink
      arrow-up
      12
      ·
      1 year ago

      Doing something shitty to a trans person is only transphobia when you’re doing it because they’re trans, yet you’ve provided no substantive evidence for this claim. It also does not align with what Ernest has said in this thread and others. Saying shit like this without evidence is trashy and irresponsible and THAT is why you’re being down voted. Do better.

    • DarkThoughts@kbin.social
      link
      fedilink
      arrow-up
      7
      arrow-down
      1
      ·
      1 year ago

      That’s not how transphobia works. That’s straight up US conservative victim complex type of framing.

    • AnonymousLlama@kbin.social
      link
      fedilink
      arrow-up
      5
      ·
      edit-2
      1 year ago

      You’re getting downvoted because you’re spouting rubbish without actually providing any evidence, not because people are “transphobic”.

      Not every unfortunate action that happens to trans people can be attributed to people being “transphobic”, like it’s a coordinated attack

        • GBU_28@lemm.ee
          link
          fedilink
          English
          arrow-up
          3
          ·
          1 year ago

          Why would you seek to “find out”? It’s personal, GitHub is for code

          • gsa4555@lemm.ee
            link
            fedilink
            arrow-up
            2
            arrow-down
            6
            ·
            1 year ago

            Ask them, not me. I found it through the raddle link at the top comment.

            • GBU_28@lemm.ee
              link
              fedilink
              English
              arrow-up
              4
              ·
              1 year ago

              But you amplified that info with your comment, seems odd to do so

              • AnonymousLlama@kbin.social
                link
                fedilink
                arrow-up
                5
                ·
                1 year ago

                Probably putting out another strawman argument to make the situation much worse than it actually it. Making it go from a scenario where licensing wasn’t followed correctly to a proposed new outrage where hard work from stolen from a trans person. Pathetic