• priapus
    link
    fedilink
    English
    arrow-up
    5
    ·
    9 months ago

    Awesome! I’m glad I’ll be able to use format on save in Helix without screwing up my Nixpkgs commits.

    • Atemu@lemmy.mlOP
      link
      fedilink
      English
      arrow-up
      3
      ·
      9 months ago

      Note that it’ll still be a while until Nixpkgs will be bulk-formatted; this RFC “only” decides on the style and how to proceed.

      • priapus
        link
        fedilink
        English
        arrow-up
        3
        ·
        9 months ago

        yeah I assume the implementation will take some time, glad to see the initial steps though!

  • onlinepersona@programming.dev
    link
    fedilink
    English
    arrow-up
    1
    arrow-down
    4
    ·
    9 months ago

    A default line length of 100 characters? Wow, they’re moving with times. None of that 80 character archaicness 👍

    The leading comma style was a lesser-evil workaround for the lack of trailing commas in the Nix language. Now that the language has this feature, there is no reason to keep it that way anymore.

    source

    Amazing! Finally that terrible style is out.

    About time they decide to format nixpkgs. That is such a mess at the moment and gives reviewers the ability to nitpick and force their own style - of course every reviewer has a different style. Only took them ~25 years, but they’re getting there 👏

    Good job on getting this through.

    CC BY-NC-SA 4.0