• vvv@programming.dev
    link
    fedilink
    arrow-up
    16
    arrow-down
    10
    ·
    1 year ago

    Mandatory pull requests + approvals within a team are a waste of everyone’s time.

    • apd@programming.dev
      link
      fedilink
      arrow-up
      6
      ·
      1 year ago

      Big hot take to me; especially in an organization with a large size and code high standard

    • uniqueid198x@lemmy.dbzer0.com
      link
      fedilink
      arrow-up
      8
      arrow-down
      3
      ·
      1 year ago

      We’v known this for twenty years and had the data ta back it up for ten. Github flow is one of the most damaging things to ever happen to software teams

        • uniqueid198x@lemmy.dbzer0.com
          link
          fedilink
          arrow-up
          2
          ·
          1 year ago

          Got asked about this twice so I’m cut/pasting my answer, but happy to discuss further

          Check out the dora reports and the data Nicole Forsgren lays out in her book Accelerate. DORA reborts are free to access. She has found clear links between trunk based (no branching) development and a whole host of positive metrics. There is some suggestion that PRs are not too bad if always done at high quality and within the same day, but its weaker.

      • 10nica [comrade/them]@hexbear.net
        link
        fedilink
        English
        arrow-up
        4
        arrow-down
        1
        ·
        1 year ago

        Omfg yes! Have nothing to add, but an upvote was not enough to express my hate for gitflow. So fucking stupid. And you’ll show stats from Jez Humble etc about trunk based, and my boss was still “eh not convinced”

        • nous@programming.dev
          link
          fedilink
          English
          arrow-up
          2
          ·
          1 year ago

          gitflow != github flow

          Gitflow is far more complex and unnessaray for most places. You do not need a dev, main, and release branches. Github flow is far closer to trunk based dev - create a branch of master, PR back into master when done. If you keep your PRs small it gives you most of the benefits of trunk based dev with a CI check before you merge to the mainline.

      • fusio@lemmy.world
        link
        fedilink
        arrow-up
        3
        ·
        1 year ago

        what data? just curios because there are so many ways to do PRs properly… like for everything, if it’s done badly better not do it. does not mean it is inherently bad

        • uniqueid198x@lemmy.dbzer0.com
          link
          fedilink
          arrow-up
          1
          ·
          1 year ago

          Check out the dora reports and the data Nicole Forsgren lays out in her book Accelerate. DORA reborts are free to access. She has found clear links between trunk based (no branching) development and a whole host of positive metrics. There is some suggestion that PRs are not too bad if always done at high quality and within the same day, but its weaker.

    • fusio@lemmy.world
      link
      fedilink
      arrow-up
      5
      ·
      1 year ago

      depends on the company/team culture. are other people gonna have to fix or extend code you wrote? are you the sole engineer working on entire modules? do you hate feedback?

    • Sigmatics@lemmy.ca
      link
      fedilink
      arrow-up
      2
      ·
      1 year ago

      Depends how good you are at what you’re doing. I’d argue that humans err and it saves a bunch of time to catch bugs before debugging in the wild