I want to add, that arms are still needed in this day-and-age, even to uphold peace. So many things are not as black and white as they seem.
I am quite happy NATO (to name one) can deter bad actors from attacking it, or in worst case use them to protect its member states. But, yes, ideally weapons would be history.
Of course, I neither wanted to portray arms sales as just something good. Unsurprisingly, states manage to have these twisted deals in the name of national interests.