• @[email protected]
    link
    fedilink
    119 days ago

    Pre-merge code review should stop that kind of thing. I honestly haven’t seen anything like this in years.

    • @[email protected]
      link
      fedilink
      English
      119 days ago

      Many code-reviewers likewise devalue tests, giving only a cursory skim over the unit-test section of PRs, if they examine them at all, and sometimes code-review itself is devalued to the point of a rubber-stamp (e.g. “great, we need someone from team X to approve it too… doesn’t matter who, though…”).

      If I could tell you, you would be SHOCKED at how high-profile and recent this sordid project was; it’s literally in the news and discussed in my podcasts.