• @[email protected]
    link
    fedilink
    English
    832 months ago

    Take me down to the PropertyCity where the SelectFoliage is #008000 and the HumanFemales.young(pretty)

    • @[email protected]
      link
      fedilink
      152 months ago

      Why are females typed differently than males instead of a base class human with a gender identity parameter? Why would human anything have a function called young?? What would that function even do???

      • @[email protected]
        link
        fedilink
        42 months ago

        HumanFemales and HumanM both inherit from the Ape base class, it’s from an older java code base. We tried to change it once but it turned out the person that had written had retired and any changes we made just broke stuff.

      • @[email protected]
        link
        fedilink
        22 months ago

        The young method returns a boolean parameter. Females have a different type for obvious biological discrepancies that require extra functionality.

        • @[email protected]
          link
          fedilink
          1
          edit-2
          2 months ago

          I can accept your second point, but in your PR I would absolutely request you to rename the method to isYoung, and then in making said comment I would then ask… what value isYoung providing, and where is the line between young and !young ultimately for trying to get the dev to reevaluate the design. It’s hyper specific in an obtuse manner and I think it hints at design flaws especially with the perspective of product evolution

      • @[email protected]
        link
        fedilink
        English
        22 months ago

        Could be a subclass. However, it should just be an ‘is’ method which is passed the array of [young, pretty] as input

    • @[email protected]
      link
      fedilink
      English
      92 months ago

      I’m more of a mountain guy so #4a522e or #3d7435 really do it for me. But hey, you do you.

    • @[email protected]
      link
      fedilink
      English
      52 months ago

      Not really relevant, but I used to think Axl was singing “take me down to the very last city”.