rglullis@communick.news to Experienced Devs@programming.devEnglish · 20 hours agoWhile reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do?cupid.careersexternal-linkmessage-square13fedilinkarrow-up124arrow-down11
arrow-up123arrow-down1external-linkWhile reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do?cupid.careersrglullis@communick.news to Experienced Devs@programming.devEnglish · 20 hours agomessage-square13fedilink
minus-squareArbitraryValuelinkfedilinkEnglisharrow-up12·18 hours agoI would make a suggestion but I wouldn’t insist on it being followed, because arguments about style are tedious and rarely productive.
I would make a suggestion but I wouldn’t insist on it being followed, because arguments about style are tedious and rarely productive.