Up for discussion:

The userscript I (and others) have written seems to be fairly popular among people who have found it. I’ve had several requests to turn it into a Lemmy theme, but I have been hesitant to do so. Partly because I lack the skill to do it, and partly because it isn’t really a “theme” as such. It doesn’t change the colors or do some of the things a theme typically does. In truth, the script is actually (essentially) theme agnostic - I use it with darkly, but it works with all of the other Lemmy themes without issue (hopefully).

I have no qualms with someone helping turn the CSS stuff into a Lemmy theme (or just taking the bull by the horns and doing it) , but with the changes coming in v.0.18 it may be better to wait.

Anyone have any thoughts? Is this script even appropriate for a Lemmy theme?

  • mershed_perderdersOPM
    link
    fedilink
    arrow-up
    3
    ·
    edit-2
    1 year ago

    So, I don’t think this could be a theme because… What you are doing is replacing the Bootstrap code itself

    yeah, this is what I thought. Makes sense and I appreciate the insight/feedback.

    As a sidenote, reading your code I saw you used the browser’s user agent to check for mobile users.

    Yes indeed. That’s coming out. New released updates handle screen width with pure CSS (the @media you mentioned) so there’s no need to check for browser type/agent anymore. In fact, I’m getting rid of basically all the functions (except for the tagline reposition which I’m pretty sure won’t be needed for v0.18).

    • Nerd02@forum.basedcount.com
      link
      fedilink
      arrow-up
      2
      ·
      1 year ago

      Is this “new version” you speak of the one you pushed 5 hours ago? I really like it! The fix to the banner in user profiles is great, it looks much nicer. Yes I really think I’m going to add this to my instance.