• Fades@lemmy.world
    link
    fedilink
    arrow-up
    185
    ·
    edit-2
    5 months ago

    WHY IS THE HEALTH INPUT PARAMETER A GODDAMN STRING???

    Why are you passing ‘%’ inside said goddamn string?!?! Not to mention the static reference instead of the actual instance.

    Shame on you

    • blind3rdeye@lemm.ee
      link
      fedilink
      arrow-up
      30
      arrow-down
      1
      ·
      edit-2
      5 months ago

      I guess its just a reminder that getting a PhD is often more about dedication than it is about practical knowledge.

    • lud@lemm.ee
      link
      fedilink
      arrow-up
      18
      ·
      5 months ago

      It’s not his fault the world is made this way.

      He just has to follow it or else that man dies.

    • Fat Tony@lemmy.world
      link
      fedilink
      arrow-up
      9
      ·
      edit-2
      5 months ago

      Honestly, if someone were to try to safe my life. And I find out he uses a string as a parameter to do so. Just let me die right there.

    • VeganPizza69 Ⓥ@lemmy.world
      link
      fedilink
      arrow-up
      11
      arrow-down
      5
      ·
      5 months ago

      The high level setter function should be made to handle both string and numeric values.

      If it contains “%” it’s a percentage value.

      If it’s a string without a “%” it’s an absolute value and needs to be normalized.

      If it’s a numeric value, it’s an absolute value.

      If it’s a numeric 100, it’s 100%.

      If it’s a subunitary numeric value, it’s a percentage.

      • sandbox@lemmy.world
        link
        fedilink
        arrow-up
        28
        ·
        5 months ago

        yeah I’m gonna go ahead and reject your PR, please change this function to accept a decimal value between 0 and 1

        • ChickenLadyLovesLife@lemmy.world
          link
          fedilink
          English
          arrow-up
          12
          ·
          5 months ago

          Ironically, the worst thing I ever saw a coworker do was to change a function that accepted an Integer value between 0 and 32767 to one that accepted a Float between 0.0 and 1.0. Perfectly sensible change except that it resulted in a 120 mph knuckleball fired a foot above a 10 year old kid’s head, followed by a fist fight between the client and my boss.

          • jaybone@lemmy.world
            link
            fedilink
            arrow-up
            11
            ·
            5 months ago

            That sounds like something that should have been caught by QA, integration tests or unit tests long before it was launching balls at ten year olds.

          • funkless_eck
            link
            fedilink
            arrow-up
            4
            ·
            5 months ago

            yeah every engineer knows you gotta set KidHeadKnuckleballClearance waaay higher than that, it’s compsci 101

      • Skates@feddit.nl
        link
        fedilink
        arrow-up
        4
        ·
        5 months ago

        Oldman.setHealth(“dicktits”); //normalize pls

        Oldman.setHealth(“-100±1%”); //make percentage pls

        Oldman.setHealth(0.0); //it is subunitary, but undefined behavior - will it access the ‘numeric value’ overload, or the ‘subunitary numeric value’ overload?

        Don’t write your own code just yet.

        • VeganPizza69 Ⓥ@lemmy.world
          link
          fedilink
          arrow-up
          3
          ·
          5 months ago

          Oldman.setHealth(“dicktits”); //normalize pls

          0

          Oldman.setHealth(“-100±1%”); //make percentage pls

          Reject operations.

          Use absolute number to remove the minus. Math.abs()

          Oldman.setHealth(0.0); //it is subunitary, but undefined behavior - will it access the ‘numeric value’ overload, or the ‘subunitary numeric value’ overload?

          Same result either way, so whatever if branch is first.

          Understand the purpose. If you want to kill the old man with 0, then there’s no point to leaving it as 0.9%, understand the non-linear characteristics of life and death.

          When you’re dealing with the low level functions, sure, you can keep it simple. When you’re reaching the surface of user input, you’re either going to waste time with validation and error reporting, or you’re going to waste time with interfaces that can handle more shit without complaining. There’s no fool proof either way, but good luck pissing users off with endless docs.

          Don’t write your own code just yet.

          If your goal in programming is just to be a traffic cop between the user input and the database, all you’re doing is building a virtual bureaucracy, the kind that people really hate and is easily generated with coding tools. Or you’re just deferring the “smoothing out” burden to the UI developers.

      • Fades@lemmy.world
        link
        fedilink
        arrow-up
        3
        ·
        5 months ago

        Yes absolutely, the parameter even if not in a strongly typed language should be a specific number and the unit should be implied. Overload the method to support different units if necessary or provide a unit as an additional parameter instead of forcing the method to parse the string for any unit type hints that may or may not be there

  • sundray@lemmus.org
    link
    fedilink
    English
    arrow-up
    28
    ·
    5 months ago

    “Wait! We need to get the user story before we start working on a solution!”

  • Ð Greıt Þu̇mpkin@lemm.ee
    link
    fedilink
    arrow-up
    14
    ·
    5 months ago

    See that’s the issue, he should have tried stopping the cardiac arrest process instead of just resetting the man to the beginning of it

    • jol@discuss.tchncs.de
      link
      fedilink
      arrow-up
      8
      ·
      5 months ago

      Patient HP kept dropping to zero after resetting, but we don’t have budget to investigate why and this was supposed to be worth only 1 story point, so we set up a microservice that runs a job every 200ms to set HP back to 100. So long as nothing shuts down the service, patient should be fine. Marking as Done.

    • ramjambamalam@lemmy.ca
      link
      fedilink
      arrow-up
      1
      ·
      edit-2
      5 months ago

      Whoops, stopped the lungs process instead of the cardiac arrest process.

      Actually you really want to restart the heart service, right? sudo systemd restart heart

  • nyan@lemmy.cafe
    link
    fedilink
    English
    arrow-up
    9
    ·
    5 months ago

    bash: sudo: command not found

    After all, we don’t know that he has it installed, especially if he’s running a really old distro.